Add Artisanal production + buying from market #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvpm
commented
Nov 4, 2024
src/openvic-simulation/economy/production/ArtisanalProducer.cpp
Outdated
Show resolved
Hide resolved
wvpm
commented
Nov 4, 2024
wvpm
commented
Nov 4, 2024
src/openvic-simulation/economy/production/ArtisanalProducer.cpp
Outdated
Show resolved
Hide resolved
wvpm
commented
Nov 4, 2024
src/openvic-simulation/economy/production/ArtisanalProducer.cpp
Outdated
Show resolved
Hide resolved
wvpm
commented
Nov 4, 2024
src/openvic-simulation/economy/production/ArtisanalProducer.cpp
Outdated
Show resolved
Hide resolved
wvpm
force-pushed
the
placeholder_market
branch
3 times, most recently
from
eac4711 to
98ed3fa
Compare
wvpm
force-pushed
the
placeholder_market
branch
5 times, most recently
from
ba40193 to
00d84ea
Compare
wvpm
force-pushed
the
placeholder_market
branch
3 times, most recently
from
b6eb317 to
1939e7c
Compare
wvpm
force-pushed
the
artisanal_production
branch
2 times, most recently
from
9fba632 to
4a8ef4d
Compare
wvpm
force-pushed
the
placeholder_market
branch
from
1939e7c to
72c6e54
Compare
wvpm
force-pushed
the
artisanal_production
branch
3 times, most recently
from
e704edf to
02c146b
Compare
wvpm
force-pushed
the
placeholder_market
branch
2 times, most recently
from
f3370e7 to
835231f
Compare
wvpm
commented
Nov 17, 2024
| {} | ||
|
|
||
| void ArtisanalProducer::artisan_tick() { | ||
| GoodDefinition::good_definition_map_t goods_to_buy_and_max_price { }; |
There was a problem hiding this comment.
Should we merge artisanal inputs and pop needs?
Can pops consume their own produce?
How is money allocated between inputs and needs?
wvpm
force-pushed
the
placeholder_market
branch
from
835231f to
72c6040
Compare
wvpm
force-pushed
the
artisanal_production
branch
from
02c146b to
4e8897d
Compare
wvpm
force-pushed
the
placeholder_market
branch
3 times, most recently
from
52be17e to
aa58b23
Compare
wvpm
force-pushed
the
artisanal_production
branch
4 times, most recently
from
898b598 to
98d7f85
Compare
wvpm
commented
Nov 19, 2024
| GoodInstance const& good_instance = market_instance.get_good_instance_manager().get_good_instance_from_definition( | ||
| production_type.get_output_good() | ||
| ); | ||
| if (!good_instance.get_is_available()) { |
There was a problem hiding this comment.
Are artisanal production types unlocked globally or per country?
If per country, we need to add that here.
wvpm
force-pushed
the
artisanal_production
branch
from
98d7f85 to
463e645
Compare
wvpm
force-pushed
the
placeholder_market
branch
from
aa58b23 to
6cca419
Compare
wvpm
force-pushed
the
artisanal_production
branch
2 times, most recently
from
8ba4fe8 to
6ce5e09
Compare
wvpm
force-pushed
the
artisanal_production
branch
3 times, most recently
from
092a655 to
e943341
Compare
Spartan322
changed the title
wvpm
force-pushed
the
artisanal_production
branch
from
e943341 to
bd97d8f
Compare
wvpm
force-pushed
the
artisanal_production
branch
3 times, most recently
from
00063dc to
6cf07b5
Compare
Spartan322
reviewed
Dec 1, 2024
Spartan322
reviewed
Dec 1, 2024
Spartan322
reviewed
Dec 1, 2024
Spartan322
reviewed
Dec 1, 2024
wvpm
force-pushed
the
artisanal_production
branch
from
6cf07b5 to
342373c
Compare
wvpm
force-pushed
the
artisanal_production
branch
from
342373c to
b9882a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Artisans will buy inputs from the market using BuyUpToOrder.
They will buy up to
input amount - amount in stockpile.As each input can bottleneck production, artisans aim to maximise
min(inputs satisfied).Based on this they allocate money to buy the inputs.
Each GoodInstance has a maximum next price, this is the price artisans take into account when allocating funds.